Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle stringOffsetType and arrayOffsetType from EXT_mesh_features #9888

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

ptrgags
Copy link
Contributor

@ptrgags ptrgags commented Oct 22, 2021

This branch is ready for review, but don't merge it until #9880 is merged.

EXT_mesh_features splits the offsetType for property table properties into stringOffsetType and arrayOffsetType

@sanjeetsuhag can you review when you get a chance?

@ptrgags ptrgags requested a review from sanjeetsuhag October 22, 2021 14:37
@cesium-concierge
Copy link

Thanks for the pull request @ptrgags!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

Base automatically changed from mesh-features-types to main October 22, 2021 18:13
@ptrgags ptrgags marked this pull request as ready for review October 22, 2021 19:40
Source/Scene/MetadataTableProperty.js Outdated Show resolved Hide resolved
Source/Scene/MetadataTableProperty.js Outdated Show resolved Hide resolved
@ptrgags
Copy link
Contributor Author

ptrgags commented Oct 22, 2021

@sanjeetsuhag updated!

Copy link
Contributor

@sanjeetsuhag sanjeetsuhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks @ptrgags!

@sanjeetsuhag sanjeetsuhag merged commit 33df071 into main Oct 22, 2021
@sanjeetsuhag sanjeetsuhag deleted the split-offset-type branch October 22, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants