-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShadowMap fade option #9565
ShadowMap fade option #9565
Conversation
Thanks for the pull request @kalosma!
Reviewers, don't forget to make sure that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kalosma! I confirmed these changes work in Sandcastle. A few things -
Had some problems with the unit test, but it seems it passed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this PR looks just about ready. Just a minor change in wording for the test case and a comment I left earlier that you might've missed (I unresolved it). Should be good to go after those changes.
Co-authored-by: Eli Bogomolny <[email protected]>
Co-authored-by: Eli Bogomolny <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kalosma. I pushed a couple changes to CHANGES.md but this is good to go 👍
Fixes #9564
Added an option to shadowMap (
shadowMap.fadingEnabled
) for enabling/disabling the shadowMap fading when the light source is close to the horizon.Having the fading disabled is desirable for cases, like the Moon, where there is no atmosphere and the shadows should be solid even if the light source is close to the horizon.
here is a sandcastle example with fading enabled (current behaviour, advance the time in timeline till the shadows fade)
fading enabled (default)
here is a sandcastle example with the new option to disable the shadows fading
fading disabled (through new option)