3D Tiles Next Metadata: Automatically unpack vector types #9495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @ptrgags!
Reviewers, don't forget to make sure that:
|
|
@lilleyse merge conflicts are fixed! |
lilleyse
approved these changes
Apr 20, 2021
| @@ -227,6 +227,7 @@ MetadataEntity.getProperty = function ( | |||
|
|
|||
| if (defined(classProperty)) { | |||
| value = classProperty.normalize(value); | |||
| value = classProperty.unpackVectorTypes(value); | |||
There was a problem hiding this comment.
In the future we may want to consider adding a result parameter to getProperty so it doesn't need to allocate the cartesian object. Looking at Cesium3DTileBatchTable it doesn't take a result parameter for getProperty either, maybe because the type could be anything without the new stricter type system?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another PR that targets the
3d-tiles-nextbranch.This PR is to maintain backwards compatibility with the old batch table, where vector types are automatically parsed as
Cartesian(2|3|4)types.The following types are automatically packed:
ARRAYs withcomponentCountof 2, 3, or 4, and one of the followingcomponentTypes:64-bit integers are NOT supported as vectors, as they are not compatible with the Cartesian classes.
Local Sandcastle
@lilleyse could you review?