Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gltf-pipeline to 3.0.2 #9477

Merged
merged 5 commits into from
Apr 9, 2021
Merged

Update gltf-pipeline to 3.0.2 #9477

merged 5 commits into from
Apr 9, 2021

Conversation

ebogo1
Copy link
Contributor

@ebogo1 ebogo1 commented Apr 9, 2021

Updates gltf-pipeline to the latest version.

Should this target master instead? I believe there are two failing specs (embedded binary KTX/CRN textures) related to CesiumGS/gltf-pipeline#550 so I targeted the new ktx2-staging branch instead.

@cesium-concierge
Copy link

Thanks for the pull request @ebogo1!

  • ✔️ Signed CLA found.
  • ❔ Changes to third party files were made.
    • Looks like a file in one of our ThirdParty folders (ThirdParty/, Source/ThirdParty/) has been added or modified. Please verify that it has a section in LICENSE.md and that its license information is up to date with this new version.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@ebogo1 ebogo1 requested a review from lilleyse April 9, 2021 15:45
CHANGES.md Outdated Show resolved Hide resolved
@lilleyse
Copy link
Contributor

lilleyse commented Apr 9, 2021

Should this target master instead?

I think it needs to target the staging branch otherwise KTX1 and CRN in glTF will break prior to us formally removing them (as you noted by the unit tests failing)

@lilleyse
Copy link
Contributor

lilleyse commented Apr 9, 2021

@ebogo1 it's also fine to delete the failing tests. At some point they'll need to be deleted, might as well be now so tests pass locally.

@ebogo1
Copy link
Contributor Author

ebogo1 commented Apr 9, 2021

@lilleyse Should be ready once 893eadd passes; I removed the two failing specs and undid the CHANGES.md section.
edit - forgot to run eslint; should be good after b13f9ed.

@ebogo1 ebogo1 mentioned this pull request Apr 9, 2021
6 tasks
@lilleyse lilleyse merged commit 726e9d1 into ktx2-staging Apr 9, 2021
@lilleyse lilleyse deleted the update-gltf-pipeline branch April 9, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants