Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use content classificationType rather than tileset classificationType #9433

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

lilleyse
Copy link
Contributor

Batched3DModel3DTileContent should be using its own internal classificationType rather than tileset.classificationType. This was missed in one spot in #9398.

In this code path content._classificationType will be the same as tileset.classificationType so this is just a cosmetic fix.

I confirmed that Photogrammetry Classification still works.

@lilleyse lilleyse requested a review from ebogo1 March 15, 2021 17:24
@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

Copy link
Contributor

@ebogo1 ebogo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @lilleyse! I'll merge once CI passes.

@ebogo1 ebogo1 merged commit c38e40b into master Mar 15, 2021
@ebogo1 ebogo1 deleted the fix-classification-type branch March 15, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants