Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return first position when interpolating rhumblines at surface distance 0.0 #9430

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

likangning93
Copy link
Contributor

In some cases, very small rhumblines can return an unexpected value when requesting a position at the beginning of the rhumbline (surface distance 0.0) using interpolateUsingSurfaceDistance.
This PR ensures that rhumbline interpolation always returns the start position when using surface distance 0.0.

@likangning93 likangning93 requested a review from dzungpng March 15, 2021 04:13
@cesium-concierge
Copy link

Thanks for the pull request @likangning93!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor

Just update CHANGES.md and this will be good to go. I can confirm the fix works on the problematic dataset.

@lilleyse lilleyse merged commit 56ab450 into master Mar 15, 2021
@lilleyse lilleyse deleted the rhumblineDistance0 branch March 15, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants