Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cesium3DTileset.pickPrimitive #9395

Merged
merged 10 commits into from
Mar 2, 2021
Merged

Add Cesium3DTileset.pickPrimitive #9395

merged 10 commits into from
Mar 2, 2021

Conversation

ebogo1
Copy link
Contributor

@ebogo1 ebogo1 commented Feb 26, 2021

  • Adds option to pass a primitive to Cesium3DTileset constructor for rendering primitives during the pick pass.

@cesium-concierge
Copy link

Thanks for the pull request @ebogo1!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@ebogo1 ebogo1 requested a review from lilleyse February 26, 2021 22:52
Specs/Scene/Cesium3DTilesetSpec.js Outdated Show resolved Hide resolved
Source/Scene/Cesium3DTileset.js Outdated Show resolved Hide resolved
Source/Scene/Cesium3DTileset.js Outdated Show resolved Hide resolved
@ebogo1
Copy link
Contributor Author

ebogo1 commented Mar 1, 2021

@lilleyse Should be ready after 7d46b8b.

@lilleyse
Copy link
Contributor

lilleyse commented Mar 2, 2021

@ebogo1 I made a few updates right at the end related to the doc and tests.

  • Changed @type {Primitive} to @type {Object} since in this context a primitive is any object that conforms to the primitive interface (which isn't super well defined, but it's an object that has an update function, a show property, and other common properties. For example, a 3D Tileset is considered a primitive. The Primitive type is specific to boxes, spheres, and other geometries.)
  • Simplified the test, mostly to ensure that all tiles are loaded after maximumScreenSpaceError is set

@lilleyse lilleyse merged commit 71340cc into master Mar 2, 2021
@lilleyse lilleyse deleted the pick-primitive branch March 2, 2021 00:38
lilleyse added a commit that referenced this pull request Mar 11, 2021
ebogo1 added a commit that referenced this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants