-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ellipsoid geodsic surface distance nan #9316
Ellipsoid geodsic surface distance nan #9316
Conversation
Thanks for the pull request @littlemurph!
Reviewers, don't forget to make sure that:
|
Thanks for the PR, @littlemurph! I'll try to review this before the next release. Thanks! |
Great thanks! I think I have everything in order now. Let me know if I missed anything else. |
Thanks @littlemurph! I confirmed the problem and the fix and made a small tweak to the test. Looks good |
This PR fixes: #9248
Given certain input, cosineTwiceSigmaMidpoint in the vincentyInverseFormula could be -INFINITY which was not being checked by the isNaN. Changed to isFinite to cover both cases.