Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to using terser plugin instead of uglify #9214

Closed
wants to merge 1 commit into from

Conversation

TJKoury
Copy link
Contributor

@TJKoury TJKoury commented Oct 23, 2020

Due to changes in how [email protected] processes dependencies, rollup-plugin-uglify causes the install to fail since it is looking for a peer dependency of rollup@ >=0.66.0 <2.0.0. See here.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/rollup
npm ERR!   dev rollup@"^2.22.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.66.0 <2" from [email protected]
npm ERR! node_modules/rollup-plugin-uglify
npm ERR!   dev rollup-plugin-uglify@"^6.0.3" from the root project

In addition, rollup-plugin-terser and terser as a whole are the recommended follow-ons for uglify and can natively handle es6 modules.

Fixes #9129
Fixes #9630

@cesium-concierge
Copy link

Thanks for the pull request @TJKoury!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@TJKoury TJKoury changed the title convert to using terser plugin instead of uglify switch to using terser plugin instead of uglify Oct 24, 2020
@cesium-concierge
Copy link

Thanks again for your contribution @TJKoury!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@hpinkos
Copy link
Contributor

hpinkos commented Nov 24, 2020

Thanks @TJKoury! We might not get this in right away since NPM LTS is still 6.x, but thanks for bringing this to our attention

@TJKoury
Copy link
Contributor Author

TJKoury commented Nov 24, 2020

No problem, let me know if you need any help when the time comes.

@cesium-concierge
Copy link

Thanks again for your contribution @TJKoury!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

2 similar comments
@cesium-concierge
Copy link

Thanks again for your contribution @TJKoury!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@cesium-concierge
Copy link

Thanks again for your contribution @TJKoury!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@cesium-concierge
Copy link

Thanks again for your contribution @TJKoury!

No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@lilleyse
Copy link
Contributor

@TJKoury could you fix the merge conflicts and change the version number in package.json to ^7.0.2?

As @mramato noted in #9129 this does increase the Build/Cesium/Cesium.js size. I'm seeing 3.68MB to 3.72MB.

@mramato
Copy link
Contributor

mramato commented Jun 23, 2021

We should probably replace use of gulp-uglify as well so everything is going through terser.

@TJKoury
Copy link
Contributor Author

TJKoury commented Jun 23, 2021

@lilleyse @mramato You can close this and figure out how you want to implement it based on wanting to replace gulp-uglify as well. Ping me if you want my input.

@TJKoury TJKoury closed this Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants