-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to using terser plugin instead of uglify #9214
Conversation
Thanks for the pull request @TJKoury!
Reviewers, don't forget to make sure that:
|
Thanks again for your contribution @TJKoury! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Thanks @TJKoury! We might not get this in right away since NPM LTS is still 6.x, but thanks for bringing this to our attention |
No problem, let me know if you need any help when the time comes. |
Thanks again for your contribution @TJKoury! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
2 similar comments
Thanks again for your contribution @TJKoury! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Thanks again for your contribution @TJKoury! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Thanks again for your contribution @TJKoury! No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with |
We should probably replace use of gulp-uglify as well so everything is going through terser. |
Due to changes in how
[email protected]
processes dependencies,rollup-plugin-uglify
causes the install to fail since it is looking for a peer dependency ofrollup@ >=0.66.0 <2.0.0
. See here.In addition,
rollup-plugin-terser
andterser
as a whole are the recommended follow-ons foruglify
and can natively handle es6 modules.Fixes #9129
Fixes #9630