Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vertical rhumb line when using PolylineGeometry #9028

Merged
merged 5 commits into from
Jul 20, 2020
Merged

Conversation

baothientran
Copy link
Contributor

Fixes #8764

The issue is that when two endpoints have the same longitude and latitude but different height, the math to calculate the number of points on rhumb line will return 0.

@lilleyse can you please take a look at it? Please let me know if I need to add anything

@baothientran baothientran requested a review from lilleyse July 16, 2020 01:31
@cesium-concierge
Copy link

Thanks for the pull request @baothientran!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor

hpinkos commented Jul 20, 2020

Thanks @baothientran! I'll merge as soon as CI passes

@baothientran
Copy link
Contributor Author

@hpinkos thank you for fixing my mistakes. I should be more careful about it in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeoJSON with vertical line crashes
3 participants