Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Label backgroundPadding and backgroundColor #8949

Merged
merged 4 commits into from
Jun 15, 2020

Conversation

nmschulte
Copy link
Contributor

clone initial values to match setter behavior and other property behavior

clone initial values to match setter behavior and other property behavior
@cesium-concierge
Copy link

Thanks for the pull request @nmschulte!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor

hpinkos commented Jun 15, 2020

Good catch @nmschulte, thanks! I just made a few small changes so the function avoids creating an extra new Color and new Cartesian2 when those values were overridden by options passed in by the user.

@hpinkos hpinkos merged commit bcf22e3 into CesiumGS:master Jun 15, 2020
@nmschulte nmschulte deleted the fix-label-background-properties branch June 15, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants