Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new buttons for Sandcastle-Camera #8939

Merged
merged 3 commits into from
Jun 12, 2020

Conversation

SambaLim
Copy link
Contributor

@SambaLim SambaLim commented Jun 9, 2020

Hello, We added the features cancleFlight and completeFlight to the Camera, but we haven't been able to test it on the Sandcastle Camera. Therefore, I added buttons to test this through Sandcastle.addToolbarButton.

What do you think of adding it like this?

@cesium-concierge
Copy link

Thanks for the pull request @SambaLim!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@IanLilleyT IanLilleyT self-requested a review June 12, 2020 14:36
Copy link
Contributor

@IanLilleyT IanLilleyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these @SambaLim

I had to refactor the sandcastle to not use Sandcastle.reset since the Complete Flight and Cancel Flight buttons were triggering Sandcastle.reset and causing primitives and events to be removed.

@IanLilleyT IanLilleyT merged commit a23f6e1 into CesiumGS:master Jun 12, 2020
@SambaLim
Copy link
Contributor Author

SambaLim commented Jun 13, 2020

Thanks @IanLilleyT

I am very happy with the contribution to Cesium.js

@SambaLim SambaLim deleted the feature-SandBox-Camera branch June 15, 2020 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants