Exposing Transforms.rotationMatrixFromPositionVelocity #8934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests for Transforms.rotationMatrixFromPositionVelocity
|
Thanks for the pull request @easternmotors!
Reviewers, don't forget to make sure that:
|
…ionVelocity to CHANGES.md
|
Updated CHANGES.md |
easternmotors
changed the title
mramato
reviewed
Jun 8, 2020
Specs/Core/TransformsSpec.js
Outdated
| Cartesian3.UNIT_Y | ||
| ); | ||
| var expected = new Matrix3(0, 0, 1, 1, 0, 0, 0, 1, 0); | ||
| // using Matrix3.abs to fix the 0/-0 comparisons |
There was a problem hiding this comment.
You should be able to replace this with toEqualEpsilon throughout. For example:
expect(matrix).toEqualEpsilon(expected, CesiumMath.EPSILON14);There was a problem hiding this comment.
Awesome that works. Makes me feel a lot better
|
Thanks @easternmotors, just the one comment to address the abs usage and hopefully this will be good to go. Thanks. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added tests for Transforms.rotationMatrixFromPositionVelocity
NOTE: I wasn't able to figure out how to get the tests to pass since
Transforms.rotationMatrixFromPositionVelocitysometimes return 0 or -0 for it's 0 values. I ended up just using theMatrix3.absfunction for now but if there is a better way to handle this let me know.Handles bullet 3 from #8927