Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed flipy issue #8893

Merged
merged 4 commits into from
Jun 1, 2020
Merged

Fixed flipy issue #8893

merged 4 commits into from
Jun 1, 2020

Conversation

ebogo1
Copy link
Contributor

@ebogo1 ebogo1 commented Jun 1, 2020

Fixes #8852. Merge after release.

@ptrgags

@ebogo1 ebogo1 requested a review from ptrgags June 1, 2020 15:32
@cesium-concierge
Copy link

Thank you so much for the pull request @ebogo1! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

  • ❌ Missing CONTRIBUTORS.md entry.
  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor

lilleyse commented Jun 1, 2020

@ebogo1 I added you to the Cesium GS CLA

@ptrgags
Copy link
Contributor

ptrgags commented Jun 1, 2020

I tried the sandcastle myself, I confirmed that it's a black rectangle on master, and a gradient on this branch.

@ptrgags
Copy link
Contributor

ptrgags commented Jun 1, 2020

@lilleyse let me know it's safe to merge this now. I checked it over one last time, everything looks good.

Thanks @ebogo1!

@ptrgags ptrgags merged commit 6742ba8 into master Jun 1, 2020
@ptrgags ptrgags deleted the fix-flipy branch June 1, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PixelFormat.flipY has a bug
4 participants