-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Globe underground color #8867
Globe underground color #8867
Conversation
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
|
Feedback from #8726 (comment)
|
There seems to be a lot of |
Right, I was kind of referring to the effort as a whole (everything going into the next release on June 1st). I haven't spent enough time to understand how many are truly undeground specific, but seems like something we might want to consider looking at. Another thought, would be whether |
These two options are I need to think more about whether it makes sense to group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the comments already brought up in the PR, the code looks good
Fixed, and in the process created a cool image. |
95697a4
to
92465c3
Compare
b414fb6
to
3ac1bdf
Compare
d67ee87
to
225ed5d
Compare
@IanLilleyT updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @lilleyse !
Adds
globe.undergroundColor
andglobe.undergroundColorByDistance
for controlling how the back side of the globe is rendered when the camera is underground or the globe is translucent.With the default settings it creates an underground fog type of look