-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PolylineVolume in CZML #8841
Conversation
Thanks for the pull request @jrafidi!
Reviewers, don't forget to make sure that:
|
Thanks @jrafidi! We'll review this once we get your CLA |
@hpinkos I believe the CLA has been submitted. Have you received it on your end? |
Got it, thanks @jrafidi! I'll have time to review this later this week. |
@hpinkos Do you have time to take a look this week? Would be nice to have this in the next release. |
@jrafidi sorry, it looks like we won't be able to get this in for the June release, but I'll make sure to review it in time for the July release. Thanks for your understanding |
Finally taking a look at trying to add this to the CZML spec. Note that in CZML "cartesian" exclusively refers to a three-dimensional value X, Y, Z, where "cartesian2" exclusively refers to a two-dimensional value X, Y. So the "shape" of the volume should have been defined as a "cartesian2" list value. I think for backwards compatibility we can keep the erroneous "cartesian" property support. There are other cases like this where we still support old incorrect syntax. |
Fixes #3062
Did my best to port forward #7175. I'm somewhat fuzzy around the reference properties and time intervals and tried my best to follow other examples in the file. Please let me know if there are other test cases I should add or any other obvious issues.
CLA signing is in progress.