Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Scene.sunColor property #8774

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Removed Scene.sunColor property #8774

merged 1 commit into from
Apr 20, 2020

Conversation

YVin3D
Copy link
Contributor

@YVin3D YVin3D commented Apr 20, 2020

fixes #8517

@cesium-concierge
Copy link

Thank you so much for the pull request @YoussefV! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

  • ❌ Missing CONTRIBUTORS.md entry.
  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor

Perfect!

@lilleyse lilleyse merged commit 1ba02c3 into master Apr 20, 2020
@lilleyse lilleyse deleted the remove-suncolor branch April 20, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated scene.sunColor
3 participants