Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contour alpha #8749

Merged
merged 3 commits into from
Apr 12, 2020
Merged

Fix contour alpha #8749

merged 3 commits into from
Apr 12, 2020

Conversation

lilleyse
Copy link
Contributor

Fixes #8748

@lilleyse lilleyse requested a review from OmarShehata April 12, 2020 14:24
@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • ❔ CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@OmarShehata
Copy link
Contributor

Thanks @lilleyse ! I was just about to look into this. Works as expected and code looks good.

Will merge when green.

@OmarShehata OmarShehata merged commit 74821eb into master Apr 12, 2020
@OmarShehata OmarShehata deleted the outline-alpha branch April 12, 2020 14:58
@OmarShehata OmarShehata mentioned this pull request Apr 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarShehata OmarShehata Awaiting requested review from OmarShehata

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing contour color alpha doesn't work
3 participants
@lilleyse @cesium-concierge @OmarShehata