Fix polyline regression with log depth #8703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @kring!
Reviewers, don't forget to make sure that:
|
|
@lilleyse you're probably the best person to review this, correct? Also, SpectorJS is really useful too, so I personally don't see a reason not to include it. |
|
Cool I'll check this out tomorrow |
lilleyse
reviewed
Mar 27, 2020
|
The change looks good. @kring do you plan on pushing any other fixes in this PR or is this ready? |
|
This can be merged. I hope to do a another PR today to fix the rest of the polyline/log depth issues. |
Co-Authored-By: Sean Lilley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cesium's fancy polyline rendering sometimes needs to clip lines at the near plane. But it was still using the depth of the original vertex after clipping.
Fixes #8663
I had hoped this would fix all the log depth polyline problems, but alas no. There's still something dodgy going on with polyline depth. In any case, this was a clear bug and this fix should go into 1.68.
This PR also includes #8608 (Spector.js shader editor support) because I merged that in in order to help debug this. If anyone has a problem with that, let me know and I'll rebase this PR to remove those changes. But those changes are awesome, so please just merge them too. :)