Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LEQUAL instead of LESS for depth testing models. #8646

Merged
merged 3 commits into from
Mar 2, 2020
Merged

Conversation

kring
Copy link
Member

@kring kring commented Mar 2, 2020

This means that a glTF that has a primitive with filled faces followed by a primitive with edge lines will look like this:
image

Where previously it looked like this:
image

If this looks ok to everyone it would be really great to get it into the March CesiumJS release!

@cesium-concierge
Copy link

cesium-concierge commented Mar 2, 2020

Thanks for the pull request @kring!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse lilleyse merged commit 6048170 into master Mar 2, 2020
@lilleyse lilleyse deleted the lequal branch March 2, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants