-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further optimizes SampleModels #8579
Conversation
Thanks for the pull request @sanjeetsuhag!
Reviewers, don't forget to make sure that:
|
@sanjeetsuhag looking at the files tab, it looks like some of these files are larger than what's in master. Is that expected? |
@hpinkos Yes, these are minor size changes and it's just to do with the way the pipeline writes the glTF at the end. |
The This is more to get vertex cache optimizations and combining nodes/meshes/primitives to reduce draw calls. I should be able to verify tonight. |
Some of these models could probably benefit from PNG -> JPG conversion (when there's no alpha channel). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These models pass validation, and some of them have huge size savings (about 6 MB saved on this branch I think).
I'll refrain from merging because I don't know where you guys are in the release cycle today, but this looks good to me.
Looks good to me too. |
Optimized the glTF 2.0 models upgraded in #8539