Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further optimizes SampleModels #8579

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Further optimizes SampleModels #8579

merged 2 commits into from
Feb 3, 2020

Conversation

sanjeetsuhag
Copy link
Contributor

Optimized the glTF 2.0 models upgraded in #8539

@sanjeetsuhag sanjeetsuhag requested a review from lilleyse January 30, 2020 15:47
@cesium-concierge
Copy link

Thanks for the pull request @sanjeetsuhag!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor

hpinkos commented Jan 30, 2020

@sanjeetsuhag looking at the files tab, it looks like some of these files are larger than what's in master. Is that expected?

@sanjeetsuhag
Copy link
Contributor Author

@sanjeetsuhag looking at the files tab, it looks like some of these files are larger than what's in master. Is that expected?

@hpinkos Yes, these are minor size changes and it's just to do with the way the pipeline writes the glTF at the end.

@lilleyse
Copy link
Contributor

The addDefaults stage is probably increasing the JSON size slightly, but not enough to worry about here.

This is more to get vertex cache optimizations and combining nodes/meshes/primitives to reduce draw calls.

I should be able to verify tonight.

@emackey
Copy link
Contributor

emackey commented Jan 31, 2020

Some of these models could probably benefit from PNG -> JPG conversion (when there's no alpha channel).

Copy link
Contributor

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These models pass validation, and some of them have huge size savings (about 6 MB saved on this branch I think).

I'll refrain from merging because I don't know where you guys are in the release cycle today, but this looks good to me.

@lilleyse
Copy link
Contributor

lilleyse commented Feb 3, 2020

Looks good to me too.

@lilleyse lilleyse merged commit 342d951 into master Feb 3, 2020
@lilleyse lilleyse deleted the gltf-2-model-optimize branch February 3, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants