Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BIM tileset in clipping planes sandcastle #8555

Merged
merged 1 commit into from
Jan 19, 2020

Conversation

lilleyse
Copy link
Contributor

Fixes #8053

The previous code only works if the tileset transform and bounding sphere center are along the same surface normal, which was true of the point cloud but not the BIM tileset in the 3D Tiles Clipping Planes sandcastle.

Capture

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse lilleyse changed the title Fix BIM tileset sandcastle Fix BIM tileset in clipping planes sandcastle Jan 19, 2020
@OmarShehata
Copy link
Contributor

Thanks @lilleyse . Can confirm this fixes the issue.

@OmarShehata OmarShehata merged commit 83e6fb9 into master Jan 19, 2020
@OmarShehata OmarShehata deleted the fix-clipping-plane-sandcastle branch January 19, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is the clipping plane different from the actual cut
3 participants