Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update earcut to v2.2.1 #8528

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Update earcut to v2.2.1 #8528

merged 2 commits into from
Jan 16, 2020

Conversation

fredj
Copy link
Contributor

@fredj fredj commented Jan 13, 2020

According to the changelog, the performance for bigger inputs has been improved (5-12%).
See https://github.com/mapbox/earcut#changelog

@cesium-concierge
Copy link

Thanks for the pull request @fredj!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Changes to third party files were made.
    • Looks like a file in one of our ThirdParty folders (ThirdParty/, Source/ThirdParty/) has been added or modified. Please verify that it has a section in LICENSE.md and that its license information is up to date with this new version.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor

mramato commented Jan 16, 2020

Thanks @fredj!

@mramato mramato merged commit 0a634a2 into CesiumGS:master Jan 16, 2020
@fredj fredj deleted the update_earcut branch January 16, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants