-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace isArray.js with native Array.isArray function #8526
Conversation
Thanks for the pull request @fredj!
Reviewers, don't forget to make sure that:
|
This sounds good to me. @shunter can you think of a reason we should keep around our polyfills like this? Old version of IE that don't have support for |
@hpinkos I've wrote that the module will be removed in version 1.69; it is correct? And I guess that a new issue should be created for the actual removal. |
Matt's comment in #4554 is still the main reason. I checked and we don't currently use |
@fredj please merge in master and then we'll merge this up. Thanks again. |
Thanks @mramato, master is now merged |
ping @mramato |
Thanks. |
Related to #8515,
Array.isArray
is supported since IE 9