Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace isArray.js with native Array.isArray function #8526

Merged
merged 6 commits into from
Mar 2, 2020

Conversation

fredj
Copy link
Contributor

@fredj fredj commented Jan 13, 2020

Related to #8515, Array.isArray is supported since IE 9

@cesium-concierge
Copy link

Thanks for the pull request @fredj!

  • ✔️ Signed CLA found.
  • ❔ Changes to third party files were made.
    • Looks like a file in one of our ThirdParty folders (ThirdParty/, Source/ThirdParty/) has been added or modified. Please verify that it has a section in LICENSE.md and that its license information is up to date with this new version.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor

hpinkos commented Jan 29, 2020

This sounds good to me. @shunter can you think of a reason we should keep around our polyfills like this? Old version of IE that don't have support for Array.isArray have been out of support for a while.

@fredj
Copy link
Contributor Author

fredj commented Jan 29, 2020

@hpinkos I've wrote that the module will be removed in version 1.69; it is correct? And I guess that a new issue should be created for the actual removal.

@shunter
Copy link
Contributor

shunter commented Jan 29, 2020

can you think of a reason we should keep around our polyfills like this?

Matt's comment in #4554 is still the main reason. I checked and we don't currently use isArray at the top-level (i.e. called when the script is included) so I don't think this will affect anything.

@mramato
Copy link
Contributor

mramato commented Feb 26, 2020

@fredj please merge in master and then we'll merge this up. Thanks again.

@fredj
Copy link
Contributor Author

fredj commented Feb 27, 2020

Thanks @mramato, master is now merged

@fredj fredj mentioned this pull request Feb 27, 2020
3 tasks
@fredj
Copy link
Contributor Author

fredj commented Mar 2, 2020

ping @mramato

@mramato
Copy link
Contributor

mramato commented Mar 2, 2020

Thanks.

@mramato mramato merged commit 0642d46 into CesiumGS:master Mar 2, 2020
@fredj fredj deleted the Array.isArray branch March 2, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants