Fix lighting on Mac/Intel #8494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
|
mramato
reviewed
Dec 25, 2019
| @@ -602,7 +602,7 @@ import ModelUtility from './ModelUtility.js'; | |||
| fragmentShader += ' vec3 n = ng;\n'; | |||
| } | |||
| if (material.doubleSided) { | |||
| fragmentShader += ' if (!gl_FrontFacing)\n'; | |||
| fragmentShader += ' if (gl_FrontFacing == false)\n'; | |||
There was a problem hiding this comment.
Maybe add a comment here explaining it works around an issue and link to this PR? Otherwise a developer might "clean up" the code here and accidentally go back to the simpler ! check.
There was a problem hiding this comment.
Ah good suggestion, updated.
|
Verified that this PR fixes the lighting bug. Thanks @lilleyse! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug on Macs with Intel integrated graphics where
!gl_FrontFacingis not equivalent togl_FrontFacing == falseand this causes the glTF PBR shader to flip normals incorrectly and have the wrong lighting.I discovered the fix thanks to https://makc3d.wordpress.com/2015/09/17/alternative-to-gl_frontfacing/ which goes into other approaches in case
gl_FrontFacing == falsedoesn't work. We can explore those later if needed.Local sandcastle
Broken lighting
Fixed