-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Globe show skirts option #8489
Globe show skirts option #8489
Conversation
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
|
The PR looks good. I submitted my own commit with minor code changes including a restructuring of how skirts are generated by Even though this PR is done, there are some ideas for further skirt improvements:
None of these are high priority at this time. |
This PR adds a new property
globe.showSkirts
to allow showing/hiding terrain skirts dynamically. The main use case is to hide skirts when viewing terrain from below the surface like in the clipping planes screenshot below.The two main changes in this PR are:
Local sandcastle
CC @fredj @gberaudo