-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposed minificationFilter and magnificationFilter for Material #8473
Conversation
Thanks for the pull request @santilland!
Reviewers, don't forget to make sure that:
|
Thanks @santilland! I can confirm we just received your signed corporate CLA. |
Missed newline
Fixed wording in CHANGES.md
Thanks for the PR @santilland! I made some changes and tests, and this should be ready after another quick review. |
Changed wording material filter documentation
I pushed a fix for video materials. Local sandcastle - you need to disable CORS for the video to work locally (I use the allow-cors-access-control Chrome extension but only for dev purposes like this, use at your own risk). |
Source/Scene/Material.js
Outdated
* @type {TextureMinificationFilter} | ||
* @default {@link TextureMinificationFilter.LINEAR} | ||
*/ | ||
this.minificationFilter = defaultValue(options.minificationFilter, TextureMinificationFilter.LINEAR); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These options should be documented in the Material
constructor.
If these options only take effect before textures are created maybe they should only be documented in the constructor and not here.
Thanks @santilland and @IanLilleyT! |
Congratulations on closing the issue! I found these Cesium forum links in the comments above: If this issue affects any of these threads, please post a comment like the following:
|
Great! Thanks for the merge! |
Ok, so here goes first try at making a pull request, quite some text to read to get to know the workflow.
I signed the CLA.
This pull request is related to discussion here:
https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/cesium-dev/CacSIMIhqeo/jdpgL-v9AQAJ
and to ticket #8328
I basically tried to mimic/copy the approach taken for the imagerylayer.
A sandcastle example:
Should look like this:
On the left the current default linear approach on the right using nearest neighbor, really useful for low resolution images/materials.
Hope i did not forget anything, let me know if you need something more,
kind regards,
Daniel