Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert separate primitive framebuffer #8368

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Nov 6, 2019

Fixes #8366 and #8356

Reverts #8205. I'm going to open a separate next-release issue to add back this fix but address the depth plane problem #8356 (comment):

The points on the opposite side of the globe are rendered in the last frustum which is past the depth plane. The same thing happened in 1.62 but the points would get overwritten by globe commands in closer frustums.

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse lilleyse force-pushed the revert-separate-primitive-framebuffer branch from 674919e to 950226e Compare November 6, 2019 14:16
@mramato
Copy link
Contributor

mramato commented Nov 6, 2019

Please include a testing strategy or at least a bullet point reminding us of the need for a testing strategy so that this doesn't happen again.

@mramato mramato merged commit 6ec546b into master Nov 6, 2019
@mramato mramato deleted the revert-separate-primitive-framebuffer branch November 6, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Significant polyline artifacts with log depth off
3 participants