-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken URL in WMTS + time Sandcastle #8352
Conversation
Thanks for the pull request @OmarShehata!
Reviewers, don't forget to make sure that:
|
I'm a little confused by the double negative here. Do you want them to change as they become available or change all at once? I believe the current behavior is supposed to be that they change all at once, but @tfili implemented this feature and can confirm. |
Looking at this, I'd suggest reducing the multiplier to 7200x which provides enough time for the server to deliver all of the images and for the user to observe them. They do need to change all at once to properly represent the time dimension's properties (e.g. daily). |
Thanks again for your contribution @OmarShehata! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Sorry - I meant the latter. They should change all at once (like this Planet Satellite Imagery blog I just stumbled on). It looks like it does change all at once only when all the tiles for that layer have been loaded (so going back and forth between two iterations works as expected). Fili did mention it will try to preload tiles in the upcoming point in time but I guess I was moving the clock too fast for that to complete. I changed the multiplier to 7200 as suggested above so this is ready. |
Should there be a separate issue created to make sure they all change at once? It does not seem to be working that way currently. |
@OmarShehata is this ready? @mramato did you want to take another look at this? |
The imagery dataset is a different one than I remembered but at least the Sandcastle shows something now. 👍 |
Congratulations on closing the issue! I found these Cesium forum links in the comments above: https://groups.google.com/forum/#!topic/cesium-dev/1Gdl4FhaaDA If this issue affects any of these threads, please post a comment like the following:
|
This fixes #8310. The URL in the current sandcastle seems to no longer be valid. I found this one with some trial and error. I added a comment about where the data comes from so it'd be easy to replace with other datasets.
I also made a few other quality improvements:
I also wanted to ask how hard it would be to make the layer queue up all the new tiles and not display them until the whole layer is ready. This is because it's still kind of hard to see changes when they come piecemeal like this. So if you're trying to follow a specific hurricane for example it makes it hard to visually parse what changed from frame to frame. This originally came up on the forum:
forum thread
Deployed Sandcastle: http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/fix-wmts-sandcastle/Apps/Sandcastle/index.html?src=Web%20Map%20Tile%20Service%20with%20Time.html