Fix double globe when lighting is enabled #8348
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CesiumJS 1.63, try running:
You'll get a double globe:
You can fix this by going back to the old resolution scale behavior we had in 1.61:
This happens because in #8318 we added a multiplication by czm_pixelRatio in metersPerPixel.glsl. This caused a second globe to render at half the size when globe lighting was enabled. This fixes it by dividing back by that value. But I'm not sure if this is the right fix. @lilleyse @IanLilleyT what do you think?
@mramato is this worth a 1.63.1 patch release?
This was reported on the forum.