Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workers -> WorkersES6, Workers/Build -> Workers #8221

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Sep 25, 2019

Move Worker code into WorkersES6 and build Workers into the Workers directory. This is so we (and users) don't have to do string manipulation to rename Workers/Build -> Workers when building ES6 based apps that rely on source modules.

Move Worker code into `WorkersES6` and build Workers into the `Workers`
directory. This is so we (and users) don't have to do string manipulation
to rename `Workers/Build` -> `Workers` when building ES6 based apps that
rely on source modules.
@cesium-concierge
Copy link

Thanks for the pull request @mramato!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato mramato merged commit c7b295e into es6-viewer Sep 25, 2019
@mramato mramato deleted the es6-move-workers branch September 25, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants