-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added credits for DataSources and Model #8173
Conversation
Thanks for the pull request @tfili!
Reviewers, don't forget to make sure that:
|
@lilleyse I just wanted to make sure what I did in |
I think hooking this in in |
Agreed.
Is there a need for another event? There is already |
@tfili yeah, looking at the code, you'll either need to add another event, or move where |
This should be good. To test
|
CHANGES.md? |
Works great @tfili! Update CHANGES and I'll merge this in |
@hpinkos Done! |
credit
options forCZML
,KML
andGeoJson
data sources as well as forModel
.scene.postRender
callbacks to add credits. This was required forDataSource
credits.