Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless argument of ScreenSpaceEventHandler #8160

Merged
merged 2 commits into from
Sep 18, 2019
Merged

remove useless argument of ScreenSpaceEventHandler #8160

merged 2 commits into from
Sep 18, 2019

Conversation

bbbbx
Copy link
Contributor

@bbbbx bbbbx commented Sep 14, 2019

@cesium-concierge
Copy link

Thank you so much for the pull request @bbbbx! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

  • ❌ Missing CONTRIBUTORS.md entry.
  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@bbbbx
Copy link
Contributor Author

bbbbx commented Sep 14, 2019

I have signed the CLA.

@hpinkos
Copy link
Contributor

hpinkos commented Sep 18, 2019

@OmarShehata have we received a CLA?

@OmarShehata
Copy link
Contributor

@hpinkos yes, CLA is signed!

@hpinkos
Copy link
Contributor

hpinkos commented Sep 18, 2019

Thanks for the contribution @bbbbx !

@hpinkos hpinkos merged commit b5fec75 into CesiumGS:master Sep 18, 2019
@cesium-concierge
Copy link

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/forum/?hl=en#!topic/cesium-dev/huOer7E71Iw](https

If this issue affects any of these threads, please post a comment like the following:

The issue at #8160 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

@bbbbx bbbbx deleted the fix-ScreenSpaceEventHandler branch September 18, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants