Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed atmosphere exposure constant (for non HDR) to make atmosphere brighter #8153

Merged
merged 2 commits into from
Sep 12, 2019

Conversation

IanLilleyT
Copy link
Contributor

Fixes #8149

@IanLilleyT IanLilleyT requested a review from lilleyse September 11, 2019 21:44
@cesium-concierge
Copy link

Thanks for the pull request @IanLilleyT!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor

@IanLilleyT can you add an entry to CHANGES.md?

Also just out of curiosity can you post the commit where this change was first introduced?

@IanLilleyT
Copy link
Contributor Author

Added to CHANGES.md. The change was first introduced in 8cf28a6

@lilleyse
Copy link
Contributor

👍

@lilleyse lilleyse merged commit 453084d into master Sep 12, 2019
@lilleyse lilleyse deleted the atmosphereHighDynamicRangeFix branch September 12, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atmsophere is dark when HDR is off
3 participants