Get rid of defineSuite #8120
Get rid of defineSuite #8120
Conversation
Cesium traditionally had a custom `defineSuite` function that wrapped both the `define` used for importing requrejs modules and the `describe` used to define a jasmine test block. In order to move to ES6, we need to get rid of this helper function and just use separate`define`/`describe` calls. Then, when we move to ES6, the describe calls will stay as-is and the define call will be replaced with ES6 module imports. Since we also overloaded describe calls for category support, this was an easy change to make and has zero functional changes. To make the diff easy, I left indentation as-is. When we move to ES6, the indentation will actually go back to being correct.
|
Thanks for the pull request @mramato!
Reviewers, don't forget to make sure that:
|
|
Bump. Now that the release is out, it would be a good time to get this merged. CC @OmarShehata |
|
I was hoping to see two separate commits, one for the codebase-wide find all and replace, and one for the non-automated changes like the docs, Was there anything else the custom |
Nope. (Technically yes it had a second parameter that was a category, but it also did this for descrive already so it's zero functionality change). |
Also, there were no "changes" in this files per-se, it was just straight up delete the function. The diff is really not bad at all. |
It was more just that it was hard to find which files had these deletions among all the find-and-replace spec files. |
Cesium traditionally had a custom
defineSuitefunction that wrapped both thedefineused for importing requrejs modules and thedescribeused to define a jasmine test block.In order to move to ES6, we need to get rid of this helper function and just use separate
define/describecalls. Then, when we move to ES6, the describe calls will stay as-is and the define call will be replaced with ES6 module imports.Since we also overloaded describe calls for category support, this was an easy change to make and has zero functional changes.
To make the diff easy, I left indentation as-is. When we move to ES6, the indentation will actually go back to being correct.
This is a test-only change.