Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polygon graphics document default values updated #8119

Merged
merged 2 commits into from
Sep 18, 2019

Conversation

abu271
Copy link

@abu271 abu271 commented Aug 29, 2019

Hey @OmarShehata I updated the documentation, let me know if more changes need to be made.

@cesium-concierge
Copy link

Thanks for the pull request @abuDarda97!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@OmarShehata
Copy link
Contributor

Thanks @abuDarda97 ! To help me out, can you post the lines of code that show where the default is being created to that value so I can easily verify?

Also, did you do a "find all" across all the files of code in the Source/ folder to see if there are any other heightReference values that are similarly missing a doc in other files?

@abu271
Copy link
Author

abu271 commented Aug 31, 2019

@OmarShehata The default heightReference value is defined here https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/DataSources/PolygonGraphics.js#L156

For extrudedHeightReference it is stated here https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/DataSources/PolygonGraphics.js#L173

I just carried out a find all search query for heightReference under the Source folder. I found a few files where the default value for heightReference is missing. I would update these files ASAP.

@hpinkos
Copy link
Contributor

hpinkos commented Sep 18, 2019

Thanks or the PR @abuDarda97! This looks fine to me.

@hpinkos hpinkos merged commit 26d87ea into CesiumGS:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants