Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace jscoverage with karma-coverage #8115

Merged
merged 3 commits into from
Aug 30, 2019
Merged

Replace jscoverage with karma-coverage #8115

merged 3 commits into from
Aug 30, 2019

Commits on Aug 28, 2019

  1. Replace jscoverage with karma-coverage

    1. Replace our ancient, windows-only jscoverage implementation with
    karma-coverage, which works on all platforms and does not require a
    separate instrumentation step. You now run coverage by simply typing
    `npm run coverage`. This also provides improved results, such as branch
    coverage, which the old system did not.
    2. Updated Testing Guide
    3. Remove old instrument link from index.html
    4. Remove jscoverage and related code.
    mramato committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    b9fe8f3 View commit details
    Browse the repository at this point in the history
  2. Run coverage as part of unit tests during CI

    1. Add options from the `test` task to the `coverage` task
    2. Run `coverage` instead of `test` on CI (since covereage includes text)
    3. Add link to coverage results in index.html and also as part of the
    the GitHub deploy information.
    mramato committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    cb496c6 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2019

  1. Coverage changes after review.

    1. Auto-generate a index.html with a list of browsers with coverage results
    2. Remove `Instrumented` from everywhere since it doesnt exist.
    3. Add Coverage to npmignore.
    mramato committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    c243d42 View commit details
    Browse the repository at this point in the history