Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed selection filtering for bloom #8056

Merged
merged 4 commits into from
Aug 16, 2019

Conversation

ProjectBarks
Copy link
Contributor

@ProjectBarks ProjectBarks commented Aug 13, 2019

Right now you can apply certain post process effects to just one feature. The bloom shader doesn't do any check to allow you to apply it to just to the selected feature as you would expect. Bloom post-processing is fixed by adding in the proper selection checks.

This is in reference to #7984

I was able to test using this sandcastle

@cesium-concierge
Copy link

Thanks for the pull request @ProjectBarks!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor

mramato commented Aug 14, 2019

@OmarShehata or @lilleyse is this good with you?

@OmarShehata
Copy link
Contributor

This looks good at first glance. It still won't allow you to select entities as features to apply the post processing to (as Brandon notes here #7984 (comment)) but it's still a useful fix.

@ProjectBarks can you:

  1. Check if any of the other post processing effects are missing a selected snippet like this? Would be good for consistency if it's easy to have them all respect this array.
  2. Post more details about what you've found about why "only some entities/primitives" can be selected? You can put that in the linked issue. I thought it was just that you had to supply a primitive but it sounds like it's not that simple?

@ProjectBarks
Copy link
Contributor Author

ProjectBarks commented Aug 14, 2019

Responded in GitHub issue.

@mramato
Copy link
Contributor

mramato commented Aug 16, 2019

@ProjectBarks please merge in master.

Where are we with this, is it just waiting for review? @lilleyse need to take a look at this or is @OmarShehata comfortable with these changes?

@OmarShehata
Copy link
Contributor

This looks good to me.

@OmarShehata OmarShehata merged commit 4537d32 into CesiumGS:master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants