Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing wall segments for some extruded polygons #8035

Closed
wants to merge 4 commits into from

Conversation

likangning93
Copy link
Contributor

When generating vertices and indices for extruded polygons, we only generate indices for vertices that aren't too close together. However, the array that we were allocating for these indices was sometimes too small, which was most apparent with rhumbline polygons like geojson. This PR allocates a larger array up-front and slices it down to size after all indices have been generated.

I'm not 100% sure how the original index count was computed, @hpinkos @lilleyse is any of that familiar?

@cesium-concierge
Copy link

Thanks for the pull request @likangning93!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor

hpinkos commented Aug 5, 2019

@likangning93 do you have a sandcastle example to reproduce this? Your fix doesn't look right to me.

@likangning93
Copy link
Contributor Author

@OmarShehata
Copy link
Contributor

I can confirm this fixes the issue I was seeing which came up on the forum here.

@hpinkos
Copy link
Contributor

hpinkos commented Aug 9, 2019

I'll take a closer look at this soon

@cesium-concierge
Copy link

Thanks again for your contribution @likangning93!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@hpinkos
Copy link
Contributor

hpinkos commented Sep 18, 2019

Replaced by #8177

@hpinkos hpinkos closed this Sep 18, 2019
@cesium-concierge
Copy link

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/d/msg/cesium-dev/kaAIg-6-XdM/-ob0p_wlBgAJ

If this issue affects any of these threads, please post a comment like the following:

The issue at #8035 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

@likangning93 likangning93 deleted the fixExtrudedPolygon branch September 20, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants