Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ground polyline texcoords bug for first segment on some platforms #8024

Merged
merged 1 commit into from
Jul 22, 2019
Merged

fix ground polyline texcoords bug for first segment on some platforms #8024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Change Log

##### Fixes :wrench:
* `PolygonGraphics.hierarchy` now converts constant array values to a `PolygonHierarchy` when set, so code that accesses the value of the property can rely on it always being a `PolygonHierarchy`.
* Fixed a bug with lengthwise texture coordinates in the first segment of ground polylines, as observed in some WebGL implementations such as Chrome on Linux. [#8017](https://github.com/AnalyticalGraphicsInc/cesium/issues/8017)

### 1.59 - 2019-07-01

Expand Down
4 changes: 2 additions & 2 deletions Source/Core/GroundPolylineGeometry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,7 @@ define([

var texcoordNormalization = texcoordNormalization3DY * topBottomSide;
if (texcoordNormalization === 0.0 && topBottomSide < 0.0) {
texcoordNormalization = Number.POSITIVE_INFINITY;
texcoordNormalization = 9.0; // some value greater than 1.0
}
rightNormalAndTextureCoordinateNormalizationY[wIndex] = texcoordNormalization;

Expand All @@ -1038,7 +1038,7 @@ define([

texcoordNormalization = texcoordNormalization2DY * topBottomSide;
if (texcoordNormalization === 0.0 && topBottomSide < 0.0) {
texcoordNormalization = Number.POSITIVE_INFINITY;
texcoordNormalization = 9.0; // some value greater than 1.0
}
texcoordNormalization2D[vec2Index + 1] = texcoordNormalization;
}
Expand Down