Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArcGIS link fix #7982

Merged
merged 3 commits into from
Jul 6, 2019
Merged

ArcGIS link fix #7982

merged 3 commits into from
Jul 6, 2019

Conversation

slchow
Copy link
Contributor

@slchow slchow commented Jul 4, 2019

Link correction emailed to us from the community.

@cesium-concierge
Copy link

Thanks for the pull request @slchow!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@OmarShehata
Copy link
Contributor

Thanks @slchow ! I can see that the old URL gets redirected to this new one. You might want to keep the format as @see {@link https://developers.arcgis.com/rest/|ArcGIS Server REST API}, that way when it appears in the docs it's "ArcGIS Server REST API" instead of "https://developers.arcgis.com/rest/".

@slchow
Copy link
Contributor Author

slchow commented Jul 5, 2019

Thanks @OmarShehata! Better?

@OmarShehata OmarShehata merged commit 969f126 into CesiumGS:master Jul 6, 2019
@OmarShehata
Copy link
Contributor

Thanks @slchow !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants