Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLA instructions #7971

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Update CLA instructions #7971

merged 2 commits into from
Jul 3, 2019

Conversation

OmarShehata
Copy link
Contributor

@OmarShehata OmarShehata commented Jun 28, 2019

I think we're ready to debut the new CLA system. Instead of having to fill out and email us a PDF, new contributors can now just fill out a Google Form. This is also going to be significantly easier for us to maintain since it's much more automated now.

@pjcozzi let me know what you think of the wording. Feel free to test fill-out the form(s) too. I will merge this Monday morning if all looks good to coordinate the Concierge deploy to switch over to this. Any contributors that are waiting to sign a CLA can go ahead and fill out this new form now.

TODO:

  • Update the links on Contributors.md
  • Remove the cla.txt currently linked there ^
    • Each signer automatically gets a copy of what they signed in their email, and we do keep a PDF copy of each version of the form in case we update it in the future for any reason, so I think this is OK.

@OmarShehata OmarShehata requested a review from pjcozzi June 28, 2019 20:02
@cesium-concierge
Copy link

Thanks for the pull request @OmarShehata!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 28, 2019

I didn't test the forms but this all looks OK to me. Please confirm that there was no material changes to the CLAs.

Also, perhaps consider making this in the corporate agreement two separate forms:

Point of contact name & title

Perhaps someone else should test and merge?

@OmarShehata
Copy link
Contributor Author

Please confirm that there was no material changes to the CLAs.

I can confirm a diff shows the only changes are AGI -> Cesium (it's defined at the top that Cesium refers to Cesium GS), and You & Your becoming you & your when not at the beginning of a sentence).

Also, perhaps consider making this in the corporate agreement two separate forms:

Done.

Perhaps someone else should test and merge?

@mramato since you're familiar with the details of the new system, do you mind filling out both forms and merging? I should get an email notification when you do.

@mramato
Copy link
Contributor

mramato commented Jul 2, 2019

@OmarShehata I filled out both forms, please let me know if you are happy the the results. (I assume you also want to undo whatever extra changes filling everything out did).

@OmarShehata
Copy link
Contributor Author

Yes, all looks good! I undid it for both forms. Please merge if you're happy with the wording on everything. @mramato

@mramato
Copy link
Contributor

mramato commented Jul 2, 2019

You & Your becoming you & your when not at the beginning of a sentence

Is this okay, legally speaking? I assume they were capitalized before for a reason?

@mramato
Copy link
Contributor

mramato commented Jul 2, 2019

Once the form is done we say something like "You an go ahead and notify". Perhaps make this more specific/direct. Something like:

Leave a comment on any pending pull requests notifying us that you have signed the CLA

It shouldn't be optional.

@mramato
Copy link
Contributor

mramato commented Jul 2, 2019

That's the only comment/questions I have.

@OmarShehata
Copy link
Contributor Author

Once the form is done we say something like "You an go ahead and notify". Perhaps make this more specific/direct. Something like:

Updated!

Is this okay, legally speaking? I assume they were capitalized before for a reason?

I was wrong, looks like it is still capital in all cases when it's used as the legal definition at the top. I'm having someone on the contracts team double check this now and will merge.

@OmarShehata OmarShehata merged commit fbc4a02 into master Jul 3, 2019
@OmarShehata OmarShehata deleted the new-cla branch July 3, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants