-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CLA instructions #7971
Update CLA instructions #7971
Conversation
Thanks for the pull request @OmarShehata!
Reviewers, don't forget to make sure that:
|
I didn't test the forms but this all looks OK to me. Please confirm that there was no material changes to the CLAs. Also, perhaps consider making this in the corporate agreement two separate forms:
Perhaps someone else should test and merge? |
I can confirm a diff shows the only changes are
Done.
@mramato since you're familiar with the details of the new system, do you mind filling out both forms and merging? I should get an email notification when you do. |
@OmarShehata I filled out both forms, please let me know if you are happy the the results. (I assume you also want to undo whatever extra changes filling everything out did). |
Yes, all looks good! I undid it for both forms. Please merge if you're happy with the wording on everything. @mramato |
Is this okay, legally speaking? I assume they were capitalized before for a reason? |
Once the form is done we say something like "You an go ahead and notify". Perhaps make this more specific/direct. Something like:
It shouldn't be optional. |
That's the only comment/questions I have. |
Updated!
I was wrong, looks like it is still capital in all cases when it's used as the legal definition at the top. I'm having someone on the contracts team double check this now and will merge. |
I think we're ready to debut the new CLA system. Instead of having to fill out and email us a PDF, new contributors can now just fill out a Google Form. This is also going to be significantly easier for us to maintain since it's much more automated now.
@pjcozzi let me know what you think of the wording. Feel free to test fill-out the form(s) too. I will merge this Monday morning if all looks good to coordinate the Concierge deploy to switch over to this. Any contributors that are waiting to sign a CLA can go ahead and fill out this new form now.
TODO: