Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve struct ellipsoid caused the model to dark #7911

Closed
wants to merge 3 commits into from
Closed

Solve struct ellipsoid caused the model to dark #7911

wants to merge 3 commits into from

Conversation

verybigzhouhai
Copy link
Contributor

Solved the problem that struct ellipsoid caused the model to darken on Qualcomm platform.

Solved the problem that struct ellipsoid caused the model to darken on Qualcomm platform
@cesium-concierge
Copy link

Thank you so much for the pull request @verybigzhouhai! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

  • ❌ Missing CONTRIBUTORS.md entry.
  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@verybigzhouhai
Copy link
Contributor Author

verybigzhouhai commented Jun 6, 2019

@OmarShehata Hi,Now I am modifying the relevant code of the ellipsoid struct. Do you think it is acceptable?
I will continue to modify other structures if necessary.

@verybigzhouhai
Copy link
Contributor Author

Fixes #7651

@OmarShehata
Copy link
Contributor

Awesome, thanks so much for putting this together @verybigzhouhai ! I'll give this a review in the next couple of days. I'd definitely be curious if this also fixes #7871.

@verybigzhouhai
Copy link
Contributor Author

ok,hope to pass the review

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 9, 2019

Thanks again for contributing, @verybigzhouhai, we received your CLA.

@verybigzhouhai
Copy link
Contributor Author

This is ready!

@verybigzhouhai
Copy link
Contributor Author

Because of some setup reasons, I need to turn off this PR first, and I'll turn on the same one later.

@cesium-concierge
Copy link

Thanks for the awesome work @verybigzhouhai! Your contribution is about to launch to millions of users with the next release. 🚀

Do you mind if we tweet about it? CC @OmarShehata @slchow.

@OmarShehata
Copy link
Contributor

Just let me know when it's ready @verybigzhouhai . Ignore the concierge message there, it's something I have to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants