-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve struct ellipsoid caused the model to dark #7911
Conversation
Solved the problem that struct ellipsoid caused the model to darken on Qualcomm platform
Thank you so much for the pull request @verybigzhouhai! I noticed this is your first pull request and I wanted to say welcome to the Cesium community! The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.
Reviewers, don't forget to make sure that:
|
@OmarShehata Hi,Now I am modifying the relevant code of the ellipsoid struct. Do you think it is acceptable? |
Fixes #7651 |
Awesome, thanks so much for putting this together @verybigzhouhai ! I'll give this a review in the next couple of days. I'd definitely be curious if this also fixes #7871. |
ok,hope to pass the review |
Thanks again for contributing, @verybigzhouhai, we received your CLA. |
This is ready! |
Because of some setup reasons, I need to turn off this PR first, and I'll turn on the same one later. |
Thanks for the awesome work @verybigzhouhai! Your contribution is about to launch to millions of users with the next release. 🚀 Do you mind if we tweet about it? CC @OmarShehata @slchow. |
Just let me know when it's ready @verybigzhouhai . Ignore the concierge message there, it's something I have to fix. |
Solved the problem that struct ellipsoid caused the model to darken on Qualcomm platform.