-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camera improvement when moving to a rectangle which crosses the antimeridian #7909
Camera improvement when moving to a rectangle which crosses the antimeridian #7909
Conversation
Thanks for the pull request @michaelhayes-dev!
Reviewers, don't forget to make sure that:
|
CLA has been sent in |
Re-ran the tests on my machine and I reproduced the same error Travis threw, but I also got that error on my unmodified master branch too. It appears to be an issue with some of the node_modules; I will investigate further this evening. |
Thanks again for contributing, @michaelhayes-dev! We received your CLA. |
Not sure if this was lost amidst everything else, but this is ready to be merged! |
Thanks again for your contribution @michaelhayes-dev! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Thanks for the contribution @michaelhayes-dev ! @hpinkos are you the best person to look at this? Seems like a straightforward PR for an issue multiple users have reported. |
Thanks again for your contribution @michaelhayes-dev! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Thanks for the pull request @michaelhayes-dev! This fix is great. I'll merge this as soon as CI passes |
Congratulations on closing the issue! I found these Cesium forum links in the comments above: https://groups.google.com/forum/#!msg/cesium-dev/p5ygxIQA490/mbAYcjUlBgAJ If this issue affects any of these threads, please post a comment like the following:
|
Discussed in Issue #6936
Discussed in this Cesium forum post