Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billboard 2D pick fix #7908

Merged
merged 2 commits into from
Jun 5, 2019
Merged

Billboard 2D pick fix #7908

merged 2 commits into from
Jun 5, 2019

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Jun 5, 2019

Fixes #7868

A small mistake in #7434 caused billboards not to be pickable when zoomed out in 2D view. At the zoomed out view the scene renders the globe in two sections and the viewer/scissor were not getting accounted for in GlobeDepth.

Note the diff around here https://github.com/AnalyticalGraphicsInc/cesium/pull/7434/files#diff-c0134c9a4ab93c317c6e68303fd7ff00R293. The line globeDepth._copyColorCommand.renderState = globeDepth._rs; was accidentally removed.

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@OmarShehata
Copy link
Contributor

Can confirm this fixes the issue - thanks for the speedy fix @lilleyse !

@OmarShehata OmarShehata merged commit 60c7fc1 into master Jun 5, 2019
@OmarShehata OmarShehata deleted the globe-depth-fix branch June 5, 2019 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot select entities in 2D when zoomed out
3 participants