-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CZML and Entity articulations API #7907
Conversation
# Conflicts: # Source/DataSources/ModelGraphics.js
Thanks for the pull request @emackey!
Reviewers, don't forget to make sure that:
|
Some sample articulations CZML is used in the new Sandcastle Demo.
|
Apparently Travis never got the message to GitHub about completion of the most recent build. |
Could use some tests in CzmlDataSourceSpec (patterned off the tests for nodeTransformations) Otherwise this all looks good. I'll double check that this syntax works out for czml-writer. |
I was able to get the writer working with a value directly under a property bag rather than the nodeTransformations which had an extra level. Syntax in C# looks like: using (var articulationsWriter = modelWriter.OpenArticulationsProperty())
using (var articulationWriter = articulationsWriter.OpenArticulationProperty("articulation1 stage1"))
{
articulationWriter.WriteNumber(3.5);
} So this all should work out. |
@shunter I added some tests to CzmlDataSourceSpec. I didn't attempt to regenerate the CZML ValidationDocument, can you do that? |
Yeah I can update the validation document separately. My local czml-writer changes are dependent on the changes made for #7899 so once that's merged I can add articulations on top of that. |
Support for articulations was added at the graphics primitive level in the 1.58 release (in #7835).
This PR adds support at the entity and CZML layers. The implementation is very similar to how the existing
nodeTransformations
work at those layers.