Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Undefined Min/Max Height in Inspector #7904

Merged
merged 5 commits into from
Jun 10, 2019
Merged

Fix Undefined Min/Max Height in Inspector #7904

merged 5 commits into from
Jun 10, 2019

Conversation

dennisadams
Copy link
Contributor

Fixes #7672.
Following the terrain overhaul (#7061), the min/max height properties have moved from the QuadtreeTile's data to data.tileBoundingRegion and not all places were updated.
This PR updates the cesium inspector and also a couple of other places: Globe's getHeight and QuadtreePrimitive's updateHeights which share the relevant code.
Hope I haven't missed any others.

@cesium-concierge
Copy link

Thanks for the pull request @dennisadams!

  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@kring
Copy link
Member

kring commented Jun 5, 2019

Code looks good to me, thanks @dennisadams. Just needs a CHANGES.md update and confirmation the CLA has been signed.

@hpinkos
Copy link
Contributor

hpinkos commented Jun 6, 2019

No, I don't think we've received a CLA yet.

@dennisadams See https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla for instructions for sending over a contributor license agreement. Thanks!

@dennisadams
Copy link
Contributor Author

I've just updated CHANGES.md and sent my CLA.
Thanks!

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 6, 2019

Thanks again for the contribution, @dennisadams, we received your CLA.

@kring kring merged commit 3828ad4 into CesiumGS:master Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cesium Inspector Undefined min/max in 1.55
5 participants