Reduce Bing Maps transactions and ion Bing sessions #7848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple PR to try and minimize the number of Bing transactions and ion Bing sessions over the course of a page. While we can't cache Bing metadata or ion endpoints across sessions, this type of basic caching is allowed and should dramatically reduce use for certain use cases. 1. BingMapsImageryProvider now keeps a local cache of metadata for a given url/style. This means destroying and recreating instances multiple times still only uses a single transaction. 2. IonImageryProvider now caches endpoint requests. This means that creating multiple IonImageryProviders for the same Bing asset will only use a single Bing session. While use cases like Sandcastle, which uses an iframe, won't benefit at all from this change, applications that switch base layers often or destroy/recreate the viewer as part of a SPA will see dramatic improvement.
|
Thanks for the pull request @mramato!
Reviewers, don't forget to make sure that:
|
shunter
reviewed
May 17, 2019
|
Thanks @shunter. This is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple PR to try and minimize the number of Bing transactions and ion Bing sessions over the course of a page. While we can't cache Bing metadata or ion endpoints across sessions, this type of basic caching is allowed and should dramatically reduce use for certain use cases.
BingMapsImageryProvider now keeps a local cache of metadata for a given url/style. This means destroying and recreating instances multiple times still only uses a single transaction.
IonImageryProvider now caches endpoint requests. This means that creating multiple IonImageryProviders for the same Bing asset will only use a single Bing session.
While use cases like Sandcastle, which uses an iframe, won't benefit at all from this change, applications that switch base layers often or destroy/recreate the viewer as part of a SPA will see dramatic improvement.
I'm open to other ideas to help reduce Bing transactions here, but obviously we need to stay withing the ToS for both Bing Maps and ion. If anyone has any thoughts, let me know.