Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests that delete data from custom properties since the code path is a bit different. #7844

Merged
merged 1 commit into from
May 17, 2019

Conversation

shunter
Copy link
Contributor

@shunter shunter commented May 15, 2019

No description provided.

@cesium-concierge
Copy link

Thanks for the pull request @shunter!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@shunter
Copy link
Contributor Author

shunter commented May 17, 2019

Since this is just new test methods which pass without any production code changes, I'm merging.

@shunter shunter merged commit fe914ad into master May 17, 2019
@shunter shunter deleted the customPropertyDelete branch May 17, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants