Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PostProcessStageTextureCache.clear, which previously didn't clear anything. #7812

Merged
merged 1 commit into from
May 9, 2019

Conversation

shunter
Copy link
Contributor

@shunter shunter commented May 3, 2019

Found via static code analysis.

@shunter shunter requested a review from bagnell May 3, 2019 19:29
@cesium-concierge
Copy link

Thanks for the pull request @shunter!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor

mramato commented May 8, 2019

Spoke with @bagnell offline, while this looks like a obvious bug and instamerge, he wants to add run some additional tests just to be sure nothing else is affected. (as soon as he frees up from the thing he's working right now)

@bagnell bagnell merged commit b7c448c into master May 9, 2019
@bagnell bagnell deleted the fixPostProcessStageTextureCacheClear branch May 9, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants